+1 for printing anything we got without ordering. I can imagine the ordering of the random topics records will be complicated and unpredicatable.
Thanks. Luke On Fri, Apr 22, 2022 at 10:22 PM Evans Jahja <evansjahj...@gmail.com> wrote: > Hi, everyone, > > Thanks for the comment on writing the example on KIP. I'm glad this KIP is > well received. > There's this other message queue called `nsq` with the consumer program > `nsq_tail` and it has the ability to print the topic, which is useful when > consuming from wildcard (includes), which led me to create this KIP. > > I've updated examples in the KIP, and I've also added the unit test for > this. > > As stated in the KIP, this is the expected output when we specify the > topic: > > Topic:topic value > > and this is the expected output when we specify all of the print > properties: > > NO_TIMESTAMP Partition:0 Offset:123 Topic:topic key value > > I think we can discuss if there's any requirements on the ordering. > Personally, I wouldn't care so much about the ordering, as long as the > topic is included, but let's discuss if there are any suggestions > regarding this. > > Thank you, > > Evans > > > On Wed, Apr 20, 2022 at 1:59 PM Luke Chen <show...@gmail.com> wrote: > > > Hi Evans, > > > > This is a good feature that we missed before. > > +1 to add an example. > > I saw your WIP PR already added it, please put them into the KIP. > > > > Thank you. > > Luke > > > > On Sat, Apr 16, 2022 at 7:39 AM John Roesler <vvcep...@apache.org> > wrote: > > > > > Hi Evans, > > > > > > Thanks for the KIP! > > > > > > I agree with Mickael; it would be good to see an example in the KIP. > > > > > > Otherwise, I'm in favor. > > > > > > Thanks, > > > -John > > > > > > On Fri, Apr 15, 2022, at 04:33, Mickael Maison wrote: > > > > Hi, > > > > > > > > I can't believe this was missing! Thanks for addressing this. > > > > Can you add an example of the expected output with the topic in the > > KIP? > > > > > > > > Thanks, > > > > Mickael > > > > > > > > On Sat, Apr 9, 2022 at 12:11 PM Evans Jahja <evansjahj...@gmail.com> > > > wrote: > > > >> > > > >> Good evening. > > > >> > > > >> My name is Evans, I am proposing KIP-829. > > > >> > > > >> Brief: Using `kafka-console-consumer` with `--include` argument > > listens > > > >> from multiple topics, but there is no way to know which topic the > > > message > > > >> came from. This proposal allows printing the topic name. > > > >> > > > >> Requesting for comments. > > > >> > > > >> Confluence > > > >> < > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-829%3A+%28console-consumer%29+add+print.topic+property > > > > > > > >> Github <https://github.com/apache/kafka/pull/12012> > > > >> > > > >> Best Regards, > > > >> > > > >> Evans Jahja > > > > > >
