[ https://issues.apache.org/jira/browse/KAFKA-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056323#comment-14056323 ]
Jun Rao commented on KAFKA-1528: -------------------------------- Thanks for the patch. It doesn't apply to trunk though. Are there changes other than adding the .gitattributes file? > Normalize all the line endings > ------------------------------ > > Key: KAFKA-1528 > URL: https://issues.apache.org/jira/browse/KAFKA-1528 > Project: Kafka > Issue Type: Improvement > Reporter: Evgeny Vereshchagin > Priority: Trivial > Attachments: KAFKA-1528.patch, KAFKA-1528_2014-07-06_16:20:28.patch, > KAFKA-1528_2014-07-06_16:23:21.patch > > > Hi! > I add .gitattributes file and remove all '\r' from some .bat files > See http://adaptivepatchwork.com/2012/03/01/mind-the-end-of-your-line/ and > https://help.github.com/articles/dealing-with-line-endings for explanation. > Maybe, add https://help.github.com/articles/dealing-with-line-endings to > contributing/commiting guide? -- This message was sent by Atlassian JIRA (v6.2#6252)