[ https://issues.apache.org/jira/browse/KAFKA-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056319#comment-14056319 ]
Jun Rao commented on KAFKA-1325: -------------------------------- Thanks for the patch. It seems to me that ms granularity is more general. Perhaps we can add log.retention.ms and log.roll.ms in the server config and leave the per topic config unchanged. This will also make the change backward compatible. > Fix inconsistent per topic log configs > -------------------------------------- > > Key: KAFKA-1325 > URL: https://issues.apache.org/jira/browse/KAFKA-1325 > Project: Kafka > Issue Type: Improvement > Components: log > Affects Versions: 0.8.1 > Reporter: Neha Narkhede > Labels: usability > Attachments: KAFKA-1325.patch > > > Related thread from the user mailing list - > http://mail-archives.apache.org/mod_mbox/kafka-users/201403.mbox/%3Cd8f6f3857b82c4ccd8725aba6fd68cb8%40cweb01.nmdf.nhnsystem.com%3E > Our documentation is a little confusing on the log configs. > The log property for retention.ms is in millis but the server default it maps > to is in minutes. > Same is true for segment.ms as well. We could either improve the docs or > change the per-topic configs to be consistent with the server defaults. -- This message was sent by Atlassian JIRA (v6.2#6252)