----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23208/#review47362 -----------------------------------------------------------
core/src/main/scala/kafka/network/SocketServer.scala <https://reviews.apache.org/r/23208/#comment83102> We probably should get remoteSocketAddress? core/src/main/scala/kafka/network/SocketServer.scala <https://reviews.apache.org/r/23208/#comment83097> Would it be useful to add some metrics such as avg/max connections per host? core/src/main/scala/kafka/network/SocketServer.scala <https://reviews.apache.org/r/23208/#comment83096> An InetAddress has a host and a port. It seems that we need to key on the hostName of an InetAddress. core/src/main/scala/kafka/server/KafkaConfig.scala <https://reviews.apache.org/r/23208/#comment83100> This may not work well with ipv6 since the ip will contain ":". This is also an issue for broker.list. So, do we want to address the issue now or fix it later together with broker.list? core/src/test/scala/unit/kafka/network/SocketServerTest.scala <https://reviews.apache.org/r/23208/#comment83098> Should we just fail the test if we reach here? core/src/test/scala/unit/kafka/network/SocketServerTest.scala <https://reviews.apache.org/r/23208/#comment83099> Do we really need to print the stack trace if this is expected? - Jun Rao On July 3, 2014, 10:18 p.m., Jay Kreps wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23208/ > ----------------------------------------------------------- > > (Updated July 3, 2014, 10:18 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1512 > https://issues.apache.org/jira/browse/KAFKA-1512 > > > Repository: kafka > > > Description > ------- > > KAFKA-1512 Add per-ip connection limits. > > > Diffs > ----- > > core/src/main/scala/kafka/network/SocketServer.scala > 4976d9c3a66bc965f5870a0736e21c7b32650bab > core/src/main/scala/kafka/server/KafkaConfig.scala > ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 > core/src/main/scala/kafka/server/KafkaServer.scala > c22e51e0412843ec993721ad3230824c0aadd2ba > core/src/test/scala/unit/kafka/network/SocketServerTest.scala > 1c492de8fde6582ca2342842a551739575d1f46c > > Diff: https://reviews.apache.org/r/23208/diff/ > > > Testing > ------- > > > Thanks, > > Jay Kreps > >
