Apologies, but as worded KIP-822 / KAFKA-13425 are a bit challenging to follow. I've used pause() between version 0.10 and 2.7 with EAGER protocol only and have not yet observed cases where poll() returned messages unless resume() had been called. The KIP seems to contradict this though, and indicate that poll() does return messages for EAGER protocol. Maybe a summary of the conditions where this bug occurs could help?
From: dev@kafka.apache.org At: 02/14/22 17:32:56 UTC-5:00To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-822: Optimize the semantics of KafkaConsumer#pause to be consistent between the two RebalanceProtocols Hi Luke, Yeah my understanding of the KIP are from https://issues.apache.org/jira/browse/KAFKA-13463 and https://issues.apache.org/jira/browse/KAFKA-13425, and I think we and Riven are on the same page. If the changes are just within the internal classes, I think we can just treat it as a normal bug fix and not need a KIP for it. Guozhang On Mon, Feb 14, 2022 at 2:22 AM Luke Chen <show...@gmail.com> wrote: > Hi Guozhang, > > In short, what Riven wants to do, is that we keep the `pause` flag after > rebalanced, while before this change, Rebalance does not preserve > pause/resume state as described in KAFKA-2350 > <https://issues.apache.org/jira/browse/KAFKA-2350>. > In this case, do you think we can skip the KIP and move on the > implementation? > > I'm good if we need a KIP or not, just want to make it clear in case it > breaks any existing expectation/behavior. > > Thank you. > Luke > > On Mon, Feb 14, 2022 at 10:09 AM Guozhang Wang <wangg...@gmail.com> wrote: > > > Hello Riven, > > > > > > Thanks for bringing this proposal. As we discussed on the JIRA I'm > > personally in favor of this fix. But if all the proposed changes are in > > `ConsumerCoordinator`, then we do not need a KIP since that class is > > internal only. > > > > > > Guozhang > > > > On Sat, Feb 12, 2022 at 1:35 AM Riven Sun <riven....@zoom.us.invalid> > > wrote: > > > > > Sorry, I sent this email via GMail. Refer to the contents of other > > people's > > > DISSCUSS emails. Mistakenly introduced someone else's KIP. > > > > > > The KIP related to this DISCUSS is > > > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=199534763 > > > > > > Thank you for your kindness > > > RivenSun > > > > > > On Sat, Feb 12, 2022 at 5:32 PM Riven Sun <riven....@zoom.us> wrote: > > > > > > > > > > >> Sorry, I sent this email via GMail. Refer to the contents of other > > > >> people's DISSCUSS emails. Mistakenly introduced someone else's KIP. > > > >> > > > >> The KIP related to this DISCUSS is > > > >> > > > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=199534763 > > > >> > > > >> Thank you for your kindness > > > >> RivenSun > > > >> > > > > > > > > > > > > > -- > > -- Guozhang > > > -- -- Guozhang
