Hi Mario, If you rename a metric named “yammer-metrics-count”, I think you should change it to just “metrics-count”, not to another implementation-specific name.
It might be worth considering using https://micrometer.io/ as it supports a wider array of more modern metrics reporting targets. For example, you can report timers as bucketed histograms to Prometheus which allows you to visualize them as heat maps and calculate arbitrary percentiles across all reporting instances. Taking inspiration from some other open source projects, Flink for example provides a metrics.reporter.<name>.class configuration option https://nightlies.apache.org/flink/flink-docs-release-1.14/docs/deployment/metric_reporters/ which allows you to specify one or more reporters and their parameters. Spring Boot also has support for configuring various reporters https://docs.spring.io/spring-boot/docs/current/reference/html/actuator.html#actuator.metrics as well as configuring various aspects of specific metrics https://docs.spring.io/spring-boot/docs/current/reference/html/actuator.html#actuator.metrics.customizing In any case, I support your KIP. -Shannon On 2019/08/21 13:57:14 Mario Molina wrote: > Hi there, > > I've written KIP-510 > <https://cwiki.apache.org/confluence/display/KAFKA/KIP-510%3A+Metrics+library+upgrade><https://cwiki.apache.org/confluence/display/KAFKA/KIP-510%3A+Metrics+library+upgrade%3e> > proposing the upgrade of the metrics library which Kafka is using. > > Please, have a look and let me know what you think, > Thanks, > Mario >
