Hello Jonathan, I think Bruno's point is that we can only upgrade in the bugfix releases if the old version of rocksDB has a critical bug that the new version would fix. For 6.27.3 it seems not fixing a critical bug but for a new feature, and hence unless we change the policy we cannot upgrade in 3.0.1 / 3.1.1 releases.
Guozhang On Thu, Feb 3, 2022 at 9:22 AM Jonathan Albrecht <jonathan.albre...@ibm.com> wrote: > > > > Thanks for the info Bruno. In that case, if no other concerns, I'll try > updating RocksDB to v6.27.3 on the 3.0 and 3.1 branches and file issues and > PRs if everything looks good. > > Jon > > > "Bruno Cadonna" <cado...@apache.org> wrote on 2022-02-03 10:40:00 AM: > > > From: "Bruno Cadonna" <cado...@apache.org> > > To: dev@kafka.apache.org > > Date: 2022-02-03 10:40 AM > > Subject: [EXTERNAL] Re: Kafka <= 3.1 upgrade RocksDB to v6.27.3? > > > > Hi Jonathan, > > > > We had to wait until AK 3.0 to upgrade RocksDB to 6.19.3 due to source > > compatibility issue. More specifically, we expose RocksDB APIs in Kafka > > Streams for configuring RocksDB and those RocksDB APIs changed. So > > upgrading RocksDB was actually a compatibility breaking change. We had > > to wait for the major release 3.0.0 to make the upgrade. That means, if > > the policy allows to upgrade dependencies in bugfix releases we can only > > upgrade RocksDB in bugfix releases for 3.1 and 3.0. Upgrading RocksDB in > > earlier releases would break compatibility. > > > > Best, > > Bruno > > > > On 03.02.22 15:15, Jonathan Albrecht wrote: > > > > > > > > > The rocksdbjni dependency has been upgraded to v6.27.3 on trunk and I > > > wanted to ask if it would be ok to also upgrade it to v6.27.3 on the > 3.1 > > > branch (and possibly earlier branches). I thought I should ask in case > > > there are some policies around changing dependency versions in point > > > releases. > > > > > > The motivation is that this is the first version of rocksdbjni that > > > supports s390x and it allows kafka to be built out of the box on this > > > platform. Having this support in earlier releases helps users on s390x > that > > > may need a specific minor release. > > > > > > If upgrading earlier releases is ok, how far back would be reasonable? > I'm > > > happy to create the issues and PRs and do the local testing, of course. > > > > > > Thanks, > > > > > > Jonathan Albrecht > > > Advisory Software Developer > > > Linux on IBM Z Open Source Ecosystem > > > 1 905 413 3577 Office > > > jonathan.albre...@ibm.com > > > > > > IBM > > > > -- -- Guozhang
