I like the idea of failing-fast whenever a custom impl is provided, but I suppose that that could be done for Admin as well. I agree your proposal is more ergonomic, but maybe it's okay to have a little friction in such fringe use-cases.
Ryanne On Tue, Oct 26, 2021, 6:23 AM Omnia Ibrahim <o.g.h.ibra...@gmail.com> wrote: > Hey Ryanne, Thanks fo the quick feedback. > Using the Admin interface would make everything easier, as MM2 will need > only to configure the classpath for the new implementation and use it > instead of AdminClient. > However, I have two concerns > 1. The Admin interface is enormous, and the MM2 users will need to know the > list of methods MM2 depends on and override these only instead of > implementing the whole Admin interface. > 2. MM2 users will need keep an eye on any changes to Admin interface that > impact MM2 for example deprecating methods. > Am not sure if adding these concerns on the users is acceptable or not. > One solution to address these concerns could be adding some checks to make > sure the methods MM2 uses from the Admin interface exists to fail faster. > What do you think > > Omnia > > > On Mon, Oct 25, 2021 at 11:24 PM Ryanne Dolan <ryannedo...@gmail.com> > wrote: > > > Thanks Omnia, neat idea. I wonder if we could use the existing Admin > > interface instead of defining a new one? > > > > Ryanne > > > > On Mon, Oct 25, 2021, 12:54 PM Omnia Ibrahim <o.g.h.ibra...@gmail.com> > > wrote: > > > > > Hey everyone, > > > Please take a look at KIP-787 > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-787%3A+MM2+Interface+to+manage+Kafka+resources > > > < > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-787%3A+MM2+Interface+to+manage+Kafka+resources > > > > > > > > > > Thanks for the feedback and support > > > Omnia > > > > > >
