Hi Tom, Thanks for the KIP, I have one question. Have you considered converting those classes to interfaces? This would also solve the problem. I must admit that the change is way bigger this way, but I would argue it offers a cleaner distinction and it offers more safety against mistakenly making methods public that shouldn't be.
Thanks! ——— Josep Prat Aiven Deutschland GmbH Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen m: +491715557497 w: aiven.io e: josep.p...@aiven.io On Thu, Sep 9, 2021, 16:25 Tom Bentley <tbent...@redhat.com> wrote: > Hi, > > I've written a small KIP-774 that proposes to deprecate public access to > the Admin client's *Result constructors: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-774%3A+Deprecate+public+access+to+Admin+client%27s+*Result+constructors > > I'd be grateful for any comments you may have. > > Kind regards, > > Tom >
