[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038843#comment-14038843 ]
Jun Rao commented on KAFKA-1481: -------------------------------- Thanks for the patch. I agree that the current jmx bean names are not ideal. I do have the following concerns. 1. While this may help some users, it may equally affect some other users who now would need to change their parsing of the jmx names. 2. I am not sure how wide-spread the separator issue. If it only helps a small number of users, I'd prefer that we only do that on the new consumer. 3. Other than the separator issue, there are other things that are not ideal. For example, the bean name is just unnecessarily too long. If we do want to change the bean names, perhaps we should fix other problems together as well. > Stop using dashes AND underscores as separators in MBean names > -------------------------------------------------------------- > > Key: KAFKA-1481 > URL: https://issues.apache.org/jira/browse/KAFKA-1481 > Project: Kafka > Issue Type: Bug > Components: core > Affects Versions: 0.8.1.1 > Reporter: Otis Gospodnetic > Labels: patch > Fix For: 0.8.2 > > Attachments: KAFKA-1481_2014-06-06_13-06-35.patch > > > MBeans should not use dashes or underscores as separators because these > characters are allowed in hostnames, topics, group and consumer IDs, etc., > and these are embedded in MBeans names making it impossible to parse out > individual bits from MBeans. > Perhaps a pipe character should be used to avoid the conflict. > This looks like a major blocker because it means nobody can write Kafka 0.8.x > monitoring tools unless they are doing it for themselves AND do not use > dashes AND do not use underscores. > See: http://search-hadoop.com/m/4TaT4lonIW -- This message was sent by Atlassian JIRA (v6.2#6252)