Hi Sophie/Matthias, Is it still possible to roll back the other changes without having to un-deprecate the JoinWindows.of(size) method?
On Thu, Aug 19, 2021 at 10:12 PM Sophie Blee-Goldman <sop...@confluent.io.invalid> wrote: > Just to clarify, this only affects the JoinWindows APIs. As Matthias > mentioned this KIP > will still ship partially in 3.0, specifically the APIs and changes to the > three aggregation > Windows classes: TimeWindows, SlidingWindows, and SessionWindows > > > > On Thu, Aug 19, 2021 at 6:14 PM Matthias J. Sax <mj...@apache.org> wrote: > > > As discussed on the 3.0 release thread, we discovered a blocker bug for > > 3.0 that is related to KIP-633. > > > > https://issues.apache.org/jira/browse/KAFKA-13216 > > > > We propose to partially roll-back KIP-633 API changes to "disable" the > > new buggy stream-stream join implementation to guard its usage. I > > prepared a PR for the change for 3.0 branch: > > > > https://github.com/apache/kafka/pull/11233 > > > > We don't need to roll-back anything in trunk, as we can just fix the > > join for the 3.1 there (and keep the current KIP-633 implementation > as-is). > > > > Bottom line is, that KIP-633 would only ship partially in 3.0 and will > > be completed in 3.1 release. > > > > > > Let us know if there are any concerns. Note that it's not a change to > > the KIP itself, it's just a delay in shipping it. > > > > > > -Matthias > > > > On 6/17/21 4:43 AM, Israel Ekpo wrote: > > > Thanks Mathias, > > > > > > The only concerns I have is my ability to contain the excitement when > > this > > > feature finally gets merged into trunk for the upcoming release :) > > > > > > > > > > > > On Wed, Jun 16, 2021 at 7:54 PM Matthias J. Sax <mj...@apache.org> > > wrote: > > > > > >> Quick follow up. I did a small update to the KIP with regard to > > >> https://issues.apache.org/jira/browse/KAFKA-12909 > > >> > > >> Israel, Sophie, and Guozhang did agree to this change. I don't think > we > > >> need to re-vote. > > >> > > >> Please let us know if there are any concerns. > > >> > > >> > > >> -Matthias > > >> > > >> On 4/8/21 9:19 PM, Sophie Blee-Goldman wrote: > > >>> Hey all, > > >>> > > >>> This KIP has been accepted with > > >>> > > >>> four +1 (binding) votes from John, Guozhang, Matthias, and myself > > >>> four +1 (non-binding) votes from Leah, Walker, Lotz, and Israel > > >>> > > >>> Thanks everyone. Israel will take it from here > > >>> > > >>> On Thu, Apr 8, 2021 at 2:58 PM Sophie Blee-Goldman < > > sop...@confluent.io> > > >>> wrote: > > >>> > > >>>>> I would also like to volunteer to implement it if that is ok. > > >>>> > > >>>> That would be awesome -- I've been pretty overbooked lately and was > > >>>> literally just about > > >>>> to ask for volunteers to take over this KIP. Perfect timing :) > > >>>> > > >>>> The KIP still has about 4 hours to go on the voting but it looks > like > > >>>> it'll pass, so feel free to > > >>>> start working on a PR. Thanks for volunteering! > > >>>> > > >>>> On Thu, Apr 8, 2021 at 2:55 PM Israel Ekpo <israele...@gmail.com> > > >> wrote: > > >>>> > > >>>>> I have reviewed the KIP. The motivation makes sense and the > > recommended > > >>>>> API > > >>>>> changes make sense as well. > > >>>>> > > >>>>> > > >>>>> > > >> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-633%3A+Drop+24+hour+default+of+grace+period+in+Streams > > >>>>> > > >>>>> So +1 > > >>>>> > > >>>>> I would also like to volunteer to implement it if that is ok. > > >>>>> > > >>>>> > > >>>>> > > >>>>> On Thu, Apr 8, 2021 at 5:42 PM Matthias J. Sax <mj...@apache.org> > > >> wrote: > > >>>>> > > >>>>>> +1 (binding) > > >>>>>> > > >>>>>> On 4/6/21 10:15 AM, Lotz Utfpr wrote: > > >>>>>>> Makes sense to me! +1 > > >>>>>>> > > >>>>>>> Apologies for being brief. This email was sent from my mobile > > phone. > > >>>>>>> > > >>>>>>>> On 6 Apr 2021, at 18:45, Walker Carlson > > >>>>> <wcarl...@confluent.io.invalid> > > >>>>>> wrote: > > >>>>>>>> > > >>>>>>>> This makes sense to me +1! > > >>>>>>>> > > >>>>>>>> Walker > > >>>>>>>> > > >>>>>>>>> On Tue, Apr 6, 2021 at 11:08 AM Guozhang Wang < > > wangg...@gmail.com> > > >>>>>> wrote: > > >>>>>>>>> > > >>>>>>>>> +1. Thanks! > > >>>>>>>>> > > >>>>>>>>> On Tue, Apr 6, 2021 at 7:00 AM Leah Thomas > > >>>>>> <ltho...@confluent.io.invalid> > > >>>>>>>>> wrote: > > >>>>>>>>> > > >>>>>>>>>> Thanks for picking this up, Sophie. +1 from me, non-binding. > > >>>>>>>>>> > > >>>>>>>>>> Leah > > >>>>>>>>>> > > >>>>>>>>>>> On Mon, Apr 5, 2021 at 9:42 PM John Roesler < > > vvcep...@apache.org > > >>> > > >>>>>> wrote: > > >>>>>>>>>> > > >>>>>>>>>>> Thanks, Sophie, > > >>>>>>>>>>> > > >>>>>>>>>>> I’m +1 (binding) > > >>>>>>>>>>> > > >>>>>>>>>>> -John > > >>>>>>>>>>> > > >>>>>>>>>>> On Mon, Apr 5, 2021, at 21:34, Sophie Blee-Goldman wrote: > > >>>>>>>>>>>> Hey all, > > >>>>>>>>>>>> > > >>>>>>>>>>>> I'd like to start the voting on KIP-633, to drop the awkward > > 24 > > >>>>> hour > > >>>>>>>>>>> grace > > >>>>>>>>>>>> period and improve the API to raise visibility on an > important > > >>>>>>>>> concept > > >>>>>>>>>> in > > >>>>>>>>>>>> Kafka Streams: grace period nad out-of-order data handling. > > >>>>>>>>>>>> > > >>>>>>>>>>>> Here's the KIP: > > >>>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>> > > >>>>>> > > >>>>> > > >> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-633%3A+Drop+24+hour+default+of+grace+period+in+Streams > > >>>>>>>>>>>> < > > >>>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>> > > >>>>>> > > >>>>> > > >> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-633%3A+Drop+24hr+default+grace+period > > >>>>>>>>>>>> > > >>>>>>>>>>>> > > >>>>>>>>>>>> Cheers, > > >>>>>>>>>>>> Sophie > > >>>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>> > > >>>>>>>>> > > >>>>>>>>> -- > > >>>>>>>>> -- Guozhang > > >>>>>>>>> > > >>>>>> > > >>>>> > > >>>> > > >>> > > >> > > > > > >
