Rohan, Thanks for working on this. Looks great.
+1 from me. (non-binding) Don't forget to update the *Current State* of the KIP and include the associated *JIRA IDs* once the voting is completed. https://cwiki.apache.org/confluence/display/KAFKA/KIP-761%3A+Add+Total+Blocked+Time+Metric+to+Streams On Mon, Aug 2, 2021 at 9:46 AM Walker Carlson <wcarl...@confluent.io.invalid> wrote: > Thanks for the KIP +1 from me (non binding)! > > Walker > > On Fri, Jul 30, 2021 at 1:20 PM Sophie Blee-Goldman > <sop...@confluent.io.invalid> wrote: > > > Thanks for updating the KIP, +1 (binding) > > > > -Sophie > > > > > > On Tue, Jul 27, 2021 at 9:57 AM Guozhang Wang <wangg...@gmail.com> > wrote: > > > > > Hello Rohan, > > > > > > Thanks for the KIP. As Bruno mentioned in the other thread could you > > update > > > the "New Metrics" that 1) we have sub-titles for streams, producer, > > > consumer metrics, just for clarification, and 2) update the > "producer-id" > > > etc to "client-id" to be consistent with the existing metrics. > > > > > > Otherwise, I'm +1 > > > > > > > > > Guozhang > > > > > > > > > On Mon, Jul 26, 2021 at 12:49 PM Leah Thomas > > <ltho...@confluent.io.invalid > > > > > > > wrote: > > > > > > > Hey Rohan, > > > > > > > > Thanks for pushing this KIP through. I'm +1, non-binding. > > > > > > > > Leah > > > > > > > > On Wed, Jul 21, 2021 at 7:09 PM Rohan Desai <desai.p.ro...@gmail.com > > > > > > wrote: > > > > > > > > > Now that the discussion thread's been open for a few days, I'm > > calling > > > > for > > > > > a vote on > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-761%3A+Add+Total+Blocked+Time+Metric+to+Streams > > > > > > > > > > > > > > > > > > -- > > > -- Guozhang > > > > > >
