Hi Tom, We don't want to break source code compatibility, so I think we should avoid removing this exception.
best, Colin On Mon, Jul 5, 2021, at 06:00, Tom Bentley wrote: > During code review Chia-Ping noticed that the `throws InterruptedException` > clause on the declaration of KafkaFuture#getNow() is not needed. We propose > to remove it. Note that removing it is not a source compatible change since > existing code which caught InterruptedException would get a compile error > about the exception not being thrown in the try block. > > Please reply here if you want to discuss further, otherwise we'll assume > removing it is acceptable. > > Kind regards, > > Tom > > > > On Tue, Apr 6, 2021 at 4:08 PM Tom Bentley <tbent...@redhat.com> wrote: > > > Hi, > > > > The vote passes with 4 binding +1s (Ismael, David Chia-Ping and Colin), > > and 1 non-binding +1 (Ryanne). > > > > Many thanks to those who commented and/or voted. > > > > Tom > > > > On Thu, Apr 1, 2021 at 8:21 PM Colin McCabe <cmcc...@apache.org> wrote: > > > >> +1 (binding). Thanks for the KIP. > >> > >> Colin > >> > >> > >> On Tue, Mar 30, 2021, at 20:36, Chia-Ping Tsai wrote: > >> > Thanks for this KIP. +1 (binding) > >> > > >> > On 2021/03/29 15:34:55, Tom Bentley <tbent...@redhat.com> wrote: > >> > > Hi, > >> > > > >> > > I'd like to start a vote on KIP-707, which proposes to add > >> > > KafkaFuture.toCompletionStage(), deprecate KafkaFuture.Function and > >> make a > >> > > couple of other minor cosmetic changes. > >> > > > >> > > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-707%3A+The+future+of+KafkaFuture > >> > > > >> > > Many thanks, > >> > > > >> > > Tom > >> > > > >> > > >> > >> >
