Personally, I think it might make sense to use annotations. And I agree, that we should have proper null-checks in place anyway, so existing code should not break.
But I don't feel strong about it either -- not sure if some people might have concerns? In the end, a KIP sound appropriate though. Just my 2ct. -Matthias On 6/4/21 3:08 AM, Matthew de Detrich wrote: > Hello everyone, > > I was thinking of doing a PR which involved adding @NotNull annotations to > various Kafka API's. Afaik the @NotNull annotation doesn't break binary > compatibility however it can break source compatibility. > > The point is that even though using @NotNull can break source > compatibility, if it does (assuming that the @NotNull is added > correctly) then you would have gotten a runtime NotNullException or null > related error and hence your code would have been broken anyways. > > So ultimately I guess the question is do I need to create a KIP to work on > such a task? I think technically speaking you do need to create one however > because of what I just said it may not be needed? > > Regards >
