Hi all, The KIP passes with three binding +1s from Randall, Tom, and Konstantine, and one non-binding +1 from Ryanne. I'll have a PR out shortly. Thanks to all who participated!
Cheers, Chris On Fri, Jun 4, 2021 at 9:28 PM Konstantine Karantasis <konstant...@confluent.io.invalid> wrote: > +1 (binding) but also with the note that we don't tend to require a KIP in > order to remove configurations that have been deprecated in previous KIPs. > > A jira ticket with the right release as a target should suffice. In future > KIPs adding a note that says that a feature is deprecated and may be > removed in future major releases can help make this clear in the future. > > Konstantine. > > > On Thu, Jun 3, 2021 at 10:47 AM Tom Bentley <tbent...@redhat.com> wrote: > > > +1 (binding). > > > > Thanks Chris! > > > > On Wed, Jun 2, 2021 at 11:00 PM Randall Hauch <rha...@gmail.com> wrote: > > > > > Thanks for putting this together, Chris. > > > > > > Technically, we don't need a new KIP to explicitly remove an API, > config, > > > etc. that was previously deprecated under an earlier approved KIP. But > > > KIP-174 could have been a bit more explicit (note taken for future > KIPs) > > > that deprecation means "deprecation and future removal", and KIP-738 > does > > > add a nice migration path for anyone stuck using a non-default internal > > > converter. > > > > > > So I'm +1 (binding) to just wrap this up and remove these configs. > > > > > > I'd also point out there is a wiki page [1] and dev discussion thread > [2] > > > highlighting all Connect-related KIPs, including all deprecations. I'll > > > update that page to include KIP-736, but it'd be great to have more > > > discussion there. > > > > > > Randall > > > > > > [1] > > > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=177047362 > > > [2] > > > > > > > > > https://lists.apache.org/thread.html/r01e9fa52998a337e435e5d0effca02e74b0552bdec271c1eeca39cd2%40%3Cdev.kafka.apache.org%3E > > > > > > On Tue, May 18, 2021 at 11:26 AM Ryanne Dolan <ryannedo...@gmail.com> > > > wrote: > > > > > > > +1 (non-binding) > > > > > > > > Thanks! > > > > > > > > Ryanne > > > > > > > > On Tue, May 18, 2021, 6:38 AM Chris Egerton > > <chr...@confluent.io.invalid > > > > > > > > wrote: > > > > > > > > > Hi all, > > > > > > > > > > I'd like to call for a vote on KIP-738: > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-738%3A+Removal+of+Connect%27s+internal+converter+properties > > > > > > > > > > The discussion thread (which was originally titled with "KIP-736") > > can > > > be > > > > > found here: > > > > > > > > > > > > > > > > > > > > https://mail-archives.apache.org/mod_mbox/kafka-dev/202105.mbox/%3CCAMdOrUV0bqqs-ry7Q6FkNNn21ZhODTrg2d61zE5WZJw1MpQvSQ%40mail.gmail.com%3E > > > > > > > > > > Cheers, > > > > > > > > > > Chris > > > > > > > > > > > > > > >
