So I am only changing Scala code within the core project, if there are no public interfaces within that project then yes I think you are right.
On Tue, 8 Jun 2021, 16:07 Ismael Juma, <ism...@juma.me.uk> wrote: > Hi, > > Thanks for the KIP. KIPs are meant to focus on public facing APIs, > protocols, configs, etc. The only Scala API that is public facing is the > Kafka Streams Scala API. Is this KIP focused on that? > > Ismael > > On Tue, Jun 8, 2021 at 3:29 AM Matthew de Detrich > <matthew.dedetr...@aiven.io.invalid> wrote: > > > Hello everyone, > > > > I'd like to discuss the following KIP which involves making all scala > case > > class's final due to best practices > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-754%3A+Make+Scala+case+class%27s+final > > > > Doing this for the upcoming Kafka 3.0.0 release would be ideal due to > > source breaking change. > > > > -- > > > > Matthew de Detrich > > > > *Aiven Deutschland GmbH* > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > *m:* +491603708037 > > > > *w:* aiven.io *e:* matthew.dedetr...@aiven.io > > >
