Hi Ismael, That makes sense then. I guess the rest of the deprecated methods might have similar issues like the ones you described. I see some will be covered by KAFKA-12588.
Thanks for your time explaining the reasoning behind it doesn't make sense to remove them as of yet. Shall I create a ticket for point number 3, so there is a documented place to start the discussion you mention? Best, Josep On Wed, Jun 2, 2021 at 9:32 PM Ismael Juma <ism...@juma.me.uk> wrote: > Hi, > > 1. alterConfigs cannot be removed as there are some cases that are not > possible via the incrementAlterConfigs API, there is a PR where a > discussion is ongoing https://github.com/apache/kafka/pull/10514 > 2. Consumer.poll(long) has no direct replacement (Consumer.poll(Duration) > has slightly different semantics) and is used by pretty much every > application written until the new method was introduced. I believe we > should keep it until 4.0 to avoid huge disruption. > 3. The committed methods are a bit of a grey area. The original KIP didn't > explain why they were deprecated and they are also widely used. It didn't > seem worth the disruption to our users. IMO, we should either update the > KIP with more details or reconsider the deprecation. > > Ismael > > > > On Wed, Jun 2, 2021 at 12:20 PM Josep Prat <josep.p...@aiven.io.invalid> > wrote: > > > Hi Ismael, > > > > Thanks for your quick answer. > > For example, I've seen the > > org.apache.kafka.clients.consumer.Consumer#poll(long) deprecated in > KIP-266 > > (Kafka 2.0.0) and in the same class methods > > > > > org.apache.kafka.clients.consumer.Consumer#committed(org.apache.kafka.common.TopicPartition) > > and > > > > > org.apache.kafka.clients.consumer.Consumer#committed(org.apache.kafka.common.TopicPartition, > > java.time.Duration) deprecated in > > https://issues.apache.org/jira/browse/KAFKA-8880 (Kafka 2.4.0). > > Also > > > > > org.apache.kafka.clients.admin.Admin#alterConfigs(java.util.Map<org.apache.kafka.common.config.ConfigResource,org.apache.kafka.clients.admin.Config>) > > and > > > > > org.apache.kafka.clients.admin.Admin#alterConfigs(java.util.Map<org.apache.kafka.common.config.ConfigResource,org.apache.kafka.clients.admin.Config>, > > org.apache.kafka.clients.admin.AlterConfigsOptions) both deprecated in > > Kafka 2.3. > > > > From the quick check I did, those methods in those 2 classes could be > > removed as they are deprecated for long enough and both have alternative > > methods available. > > > > There are probably some more methods that could be removed, also in other > > modules, but before spending too much time on something that might not be > > relevant, I decided to start this thread. > > > > Best, > > > > Josep > > > > On Wed, Jun 2, 2021 at 9:00 PM Ismael Juma <ism...@juma.me.uk> wrote: > > > > > Hi Josep, > > > > > > We have removed nearly all of the apis we plan to remove for 3.0. The > > > following JIRA is still in progress: > > > > > > https://issues.apache.org/jira/browse/KAFKA-12588 > > > > > > Aside from KAFKA-12588, which APIs were you thinking of that could be > > > removed in 3.0? > > > > > > Ismael > > > > > > On Wed, Jun 2, 2021 at 11:52 AM Josep Prat <josep.p...@aiven.io.invalid > > > > > wrote: > > > > > > > Hi there, > > > > I was looking at the source code and I realized that there are > several > > > > deprecated methods for long enough (2.5 or prior) that are not yet > > > removed. > > > > Given that it has already been done for Kafka Streams, does it make > > sense > > > > if I would go through the other modules and create Jira tickets for > the > > > > deprecated APIs susceptible to be removed? > > > > > > > > Best, > > > > > > > > -- > > > > > > > > Josep Prat > > > > > > > > *Aiven Deutschland GmbH* > > > > > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > > > > > *m:* +491715557497 > > > > > > > > *w:* aiven.io > > > > > > > > *e:* josep.p...@aiven.io > > > > > > > > > > > > > -- > > > > Josep Prat > > > > *Aiven Deutschland GmbH* > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > *m:* +491715557497 > > > > *w:* aiven.io > > > > *e:* josep.p...@aiven.io > > > -- Josep Prat *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen *m:* +491715557497 *w:* aiven.io *e:* josep.p...@aiven.io
