Thanks Luke for this feedback. I truly appreciate it. There is always room for improvement and I will take this guidance into consideration in the future.
Thanks Sophie for your initial feedback as well. I will review these feedback and take appropriate action On Fri, May 21, 2021 at 5:02 AM Luke Chen <show...@gmail.com> wrote: > Hi Israel, > Thanks for submitting the PR. > I've reviewed those 2 PRs and left some comments there. I also see Sophie > reviewed 1 of them. See if there are other guys available to review. > > But I'd like to suggest you look at the Contributing Code Changes > < > https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes#ContributingCodeChanges-TheReviewProcess > > > page first: > *Consider identifying committers or other contributors who have worked on > the code being changed. The easiest is to simply follow GitHub's automatic > suggestions. You can add @username in the PR description to ping them > immediately.* > > I don't think sending the review request mail to all dev group is a good > idea*, *especially, your PR just opened less than 1 day. > > But still, we are glad to see your contribution to Kafka. > Thank you very much! > > Luke > > On Fri, May 21, 2021 at 5:59 AM Israel Ekpo <israele...@gmail.com> wrote: > > > I just submitted my first two pull requests for the project today > > > > [KAFKA-12644] Add Missing Class-Level Javadoc to Exception Classes > > https://github.com/apache/kafka/pull/10741 > > > > [KAFKA-8613] Set default grace period to 0 > > KIP-633: Drop 24 hour default of grace period in Streams > > https://github.com/apache/kafka/pull/10740 > > > > When you have a moment, please take a look and share your feedback and > > thoughts. > > > > Thanks > > >
