With this wall of discussion having died down a bit of lately, I think it makes sense to bring this to a vote. I’ll start a separate thread ;)
/noa > On 7 Dec 2020, at 19:26, Gwen Shapira <g...@confluent.io> wrote: > > Sounds like a good idea :) > > At some point we may want to switch to builders - it gives you more > flexibility in how you construct all those objects. But those two > changes are unrelated. > > On Thu, Dec 3, 2020 at 9:30 AM Noa Resare <res...@apple.com.invalid> wrote: >> >> Hi there, >> >> I finally got around to write up the KIP for a change I have wanted for some >> time: >> >> KIP-692: Make AdminClient value object constructors public >> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-692:+Make+AdminClient+value+object+constructors+public> >> >> In essence: Let us encourage better patterns for testing by making it easier >> to mock AdminService. >> >> I am looking forward to hearing your thoughts on this. >> >> Cheers >> noa > > > > -- > Gwen Shapira > Engineering Manager | Confluent > 650.450.2760 | @gwenshap > Follow us: Twitter | blog
