[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011735#comment-14011735 ]
Jay Kreps commented on KAFKA-1316: ---------------------------------- [~guozhang] I think you are describing the case where the consumer failure detects the co-ordinator due to lack of a hb response, right? Presumably in that we would go about rediscovering the co-ordinator? I don't think we need to reach into the request queue and attempt to selectively reorder or remove items, that is likely to not end well. I think in the case where we failure detect the co-ordinator we will just want to reconnect, right? We can add a manual disconnect(Node) method to force that if that is more convenient... > Refactor Sender > --------------- > > Key: KAFKA-1316 > URL: https://issues.apache.org/jira/browse/KAFKA-1316 > Project: Kafka > Issue Type: Sub-task > Components: producer > Reporter: Jay Kreps > Assignee: Jay Kreps > Attachments: KAFKA-1316.patch > > > Currently most of the logic of the producer I/O thread is in Sender.java. > However we will need to do a fair number of similar things in the new > consumer. Specifically: > - Track in-flight requests > - Fetch metadata > - Manage connection lifecycle > It may be possible to refactor some of this into a helper class that can be > shared with the consumer. This will require some detailed thought. -- This message was sent by Atlassian JIRA (v6.2#6252)