> On May 28, 2014, 12:27 a.m., Guozhang Wang wrote: > > I get the same error as Neha on kafka-run-class.sh, could you double check > > if there is anything wrong with that diff? > > Sriharsha Chintalapani wrote: > I did a git diff against origin/trunk and applied as a patch but the one > uploaded to reviewboard having issue. I'll check it. > Thanks
I am not sure what exactly going wrong with the uploaded patch. I tried with creating a local patch with git diff that works fine only when uploaded review board the patch is not working. I undid changes bin/windows/kafka-run-class.bat and uploaded a patch this works fine. If it makes it easier can you remove adding perf dependencies part of class path in kafka-run-class.bat as part of this fix. Thanks - Sriharsha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21865/#review44081 ----------------------------------------------------------- On May 28, 2014, 3:40 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21865/ > ----------------------------------------------------------- > > (Updated May 28, 2014, 3:40 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1438 > https://issues.apache.org/jira/browse/KAFKA-1438 > > > Repository: kafka > > > Description > ------- > > KAFKA-1438. Migrate Kafka Client tools. > > > KAFKA-1438. Migrate Kafka Client tools. > > > Diffs > ----- > > bin/kafka-console-consumer.sh e410dde271eea996416f7a67561e45b78f8e8a69 > bin/kafka-console-producer.sh cd8ce62fe51e3ad64908146f727f73fc6e35b35e > bin/kafka-consumer-perf-test.sh 4ed3ed9fb12edf00a82c06c4e59270a60df43ecd > bin/kafka-producer-perf-test.sh b4efc29d76ff8f53a310f812b9ed3de6875465b5 > bin/kafka-run-class.sh d2fc8c0e413769bb89ada99790b90ad616044f28 > bin/kafka-simple-consumer-perf-test.sh > 2d3e3d3be21065a4d446b9f8ed2e9d31c0685456 > bin/windows/kafka-console-consumer.bat > 94b20a4d1d2d043b4c4280d00b807d1d27089ac1 > bin/windows/kafka-console-producer.bat > b116e64cc4d8b19e0038f3dd1ff41bc5eb47abab > core/src/main/scala/kafka/consumer/ConsoleConsumer.scala > 1a16c691683dda0c53f316e3c4797ea38e776574 > core/src/main/scala/kafka/producer/ConsoleProducer.scala > a2af988d99a94a20291d6a2dc9bec73197f1b756 > core/src/main/scala/kafka/server/OffsetManager.scala > 54176283e5f199d9db08e2181e7ddfbb9c801fab > perf/config/log4j.properties 542b7391550b2a8bb091a38d08583bea9b3111b6 > perf/src/main/scala/kafka/perf/ConsumerPerformance.scala > 4dde4687bada1202eaf54be2b06c2156e7726b23 > perf/src/main/scala/kafka/perf/PerfConfig.scala > a8fc6b9ec81c49c73c35172ddc5a67c6a96c799a > perf/src/main/scala/kafka/perf/ProducerPerformance.scala > 00fa90bb286900fb33a05f55e3c34c2cbb5620a1 > perf/src/main/scala/kafka/perf/SimpleConsumerPerformance.scala > c52ada0a30ae49c8d576703859b9d49348f62feb > > Diff: https://reviews.apache.org/r/21865/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
