----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21878/#review44087 -----------------------------------------------------------
clients/src/main/java/org/apache/kafka/clients/tools/ProducerPerformance.java <https://reviews.apache.org/r/21878/#comment78418> Is target_throughput in bytes/sec? clients/src/main/java/org/apache/kafka/clients/tools/ProducerPerformance.java <https://reviews.apache.org/r/21878/#comment78419> Not sure that I follow how the sleeping logic works. Could you add some comments? clients/src/main/java/org/apache/kafka/clients/tools/ProducerPerformance.java <https://reviews.apache.org/r/21878/#comment78416> Should we call this OnCompletionCallback? OnCompeletion.onCompletion() is a bit confusing. clients/src/main/java/org/apache/kafka/clients/tools/ProducerPerformance.java <https://reviews.apache.org/r/21878/#comment78417> Should we handle the error case here? - Jun Rao On May 23, 2014, 9:08 p.m., Jay Kreps wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21878/ > ----------------------------------------------------------- > > (Updated May 23, 2014, 9:08 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1468 > https://issues.apache.org/jira/browse/KAFKA-1468 > > > Repository: kafka > > > Description > ------- > > KAFKA-1468 Misc. improvements from benchmarking. > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > f1def508153b7361b8720dbcc939e06b0e7e45d3 > clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java > bc4074ec841650eff48dd8aafc1e6c712d8eae7d > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java > 3e83ae0fefb7578cccbd8dc0cd9b28f22e0951b2 > > clients/src/main/java/org/apache/kafka/clients/tools/ProducerPerformance.java > eb18739d181662e2dee5dd6a23e0181f4c740139 > clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java > a2b77226f8c58caf632a0f4665bd4e4cd93e643d > core/src/main/scala/kafka/server/KafkaConfig.scala > c7508d5568ec6b94c47d1839aa8695e2dbb76b97 > core/src/main/scala/kafka/server/RequestPurgatory.scala > c064c5c4cf1191335572da8a2caf5f95dce902c1 > core/src/main/scala/kafka/tools/TestEndToEndLatency.scala > 37a9ec27abfd0acd6c01f11d987dd719bc9138a5 > > Diff: https://reviews.apache.org/r/21878/diff/ > > > Testing > ------- > > > Thanks, > > Jay Kreps > >
