> On May 27, 2014, 5:26 p.m., Neha Narkhede wrote: > > We also want to move the *Performance out of perf into tools and remove the > > perf subproject > > Sriharsha Chintalapani wrote: > The diff contains changes necessary for moving perf classes under tools.
I applied the patch. It failed to apply on the .bat file and didn't get rid of the perf subproject. Would you mind uploading an updated patch? > On May 27, 2014, 5:26 p.m., Neha Narkhede wrote: > > perf/src/main/scala/kafka/perf/ProducerPerformance.scala, line 42 > > <https://reviews.apache.org/r/21865/diff/1/?file=589809#file589809line42> > > > > same here > > Sriharsha Chintalapani wrote: > current perf project has its own log4j.properties under perf/config and > it writes to perf.log . I thought users expects the logs goto perf.log and > tools-log4j.properties being included in the classpath by kafka-run-class.sh. > I added specific logging properties for perf related classes and using that > by referring to kafka.tools.performance. By default tools-log4j uses > ConsoleAppender and this config used by other tools to write error messages > to the console. I guess it will be convenient to have the same ConsoleAppender behavior for perf tools as well. Users can pipe the output to other files as they see fit right? - Neha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21865/#review43988 ----------------------------------------------------------- On May 23, 2014, 3:52 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21865/ > ----------------------------------------------------------- > > (Updated May 23, 2014, 3:52 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1438 > https://issues.apache.org/jira/browse/KAFKA-1438 > > > Repository: kafka > > > Description > ------- > > KAFKA-1438. Migrate Kafka Client tools. > > > Diffs > ----- > > bin/kafka-console-consumer.sh e410dde271eea996416f7a67561e45b78f8e8a69 > bin/kafka-consumer-perf-test.sh 4ed3ed9fb12edf00a82c06c4e59270a60df43ecd > bin/kafka-producer-perf-test.sh b4efc29d76ff8f53a310f812b9ed3de6875465b5 > bin/kafka-run-class.sh d2fc8c0e413769bb89ada99790b90ad616044f28 > bin/kafka-simple-consumer-perf-test.sh > 2d3e3d3be21065a4d446b9f8ed2e9d31c0685456 > bin/windows/kafka-console-consumer.bat > 94b20a4d1d2d043b4c4280d00b807d1d27089ac1 > bin/windows/kafka-run-class.bat f4d2904a3320ae756ed4171f6e99566f1f0cf963 > config/tools-log4j.properties 52f07c96019b4083fc78f62cfb0a81080327e847 > core/src/main/scala/kafka/consumer/ConsoleConsumer.scala > 24c92877cc7df20b82b7a438d39120b1caa3924d > core/src/main/scala/kafka/server/OffsetManager.scala > 54176283e5f199d9db08e2181e7ddfbb9c801fab > perf/config/log4j.properties 542b7391550b2a8bb091a38d08583bea9b3111b6 > perf/src/main/scala/kafka/perf/ConsumerPerformance.scala > 4dde4687bada1202eaf54be2b06c2156e7726b23 > perf/src/main/scala/kafka/perf/PerfConfig.scala > a8fc6b9ec81c49c73c35172ddc5a67c6a96c799a > perf/src/main/scala/kafka/perf/ProducerPerformance.scala > 00fa90bb286900fb33a05f55e3c34c2cbb5620a1 > perf/src/main/scala/kafka/perf/SimpleConsumerPerformance.scala > c52ada0a30ae49c8d576703859b9d49348f62feb > > Diff: https://reviews.apache.org/r/21865/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
