----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21676/#review43642 -----------------------------------------------------------
Ship it! Ship It! - Neha Narkhede On May 20, 2014, 1:50 a.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21676/ > ----------------------------------------------------------- > > (Updated May 20, 2014, 1:50 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1298 > https://issues.apache.org/jira/browse/KAFKA-1298 > > > Repository: kafka > > > Description > ------- > > KAFKA-1298. Controlled shutdown tool doesn't work out of the box. checking > for replicaiton factor > 1 at the leadership handoff removed shutdown broker > tool removed rmi mbean registration from KafkaController made controlled > shutdown true by default > > > Diffs > ----- > > core/src/main/scala/kafka/admin/ShutdownBroker.scala > 2dd47e7362f42b434ec8bb6b93f0cb0cb1a50a28 > core/src/main/scala/kafka/controller/KafkaController.scala > 2fa1341e340ea97c6e501f3a2730ce28aa89b43d > core/src/main/scala/kafka/server/KafkaConfig.scala > d0bbeb6e48d4a7124d28714ba865525c688ac782 > > Diff: https://reviews.apache.org/r/21676/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
