Hi Justine,

+1 (binding)

Thanks for all the work you put into this KIP!

btw, there is a typo in the DeleteTopics Request/Response schema in the
KIP, it says Metadata request.

Regards,

Rajini


On Fri, Oct 16, 2020 at 4:06 PM Satish Duggana <satish.dugg...@gmail.com>
wrote:

> Hi Justine,
> Thanks for the KIP,  +1 (non-binding)
>
> On Thu, Oct 15, 2020 at 10:48 PM Lucas Bradstreet <lu...@confluent.io>
> wrote:
> >
> > Hi Justine,
> >
> > +1 (non-binding). Thanks for all your hard work on this KIP!
> >
> > Lucas
> >
> > On Wed, Oct 14, 2020 at 8:59 AM Jun Rao <j...@confluent.io> wrote:
> >
> > > Hi, Justine,
> > >
> > > Thanks for the updated KIP. +1 from me.
> > >
> > > Jun
> > >
> > > On Tue, Oct 13, 2020 at 2:38 PM Jun Rao <j...@confluent.io> wrote:
> > >
> > > > Hi, Justine,
> > > >
> > > > Thanks for starting the vote. Just a few minor comments.
> > > >
> > > > 1. It seems that we should remove the topic field from the
> > > > StopReplicaResponse below?
> > > > StopReplica Response (Version: 4) => error_code [topics]
> > > >   error_code => INT16
> > > >     topics => topic topic_id* [partitions]
> > > >
> > > > 2. "After controller election, upon receiving the result, assign the
> > > > metadata topic its unique topic ID". Will the UUID for the metadata
> topic
> > > > be written to the metadata topic itself?
> > > >
> > > > 3. The vote request is designed to support multiple topics, each of
> them
> > > > may require a different sentinel ID. Should we reserve more than one
> > > > sentinel ID for future usage?
> > > >
> > > > 4. UUID.randomUUID(): Could we clarify whether this method returns
> any
> > > > sentinel ID? Also, how do we expect the user to use it?
> > > >
> > > > Thanks,
> > > >
> > > > Jun
> > > >
> > > > On Mon, Oct 12, 2020 at 9:54 AM Justine Olshan <jols...@confluent.io
> >
> > > > wrote:
> > > >
> > > >> Hi all,
> > > >>
> > > >> After further discussion and changes to this KIP, I think we are
> ready
> > > to
> > > >> restart this vote.
> > > >>
> > > >> Again, here is the KIP:
> > > >>
> > > >>
> > >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-516%3A+Topic+Identifiers
> > > >>
> > > >> The discussion thread is here:
> > > >>
> > > >>
> > >
> https://lists.apache.org/thread.html/7efa8cd169cadc7dc9cf86a7c0dbbab1836ddb5024d310fcebacf80c@%3Cdev.kafka.apache.org%3E
> > > >>
> > > >> Please take a look and vote if you have a chance.
> > > >>
> > > >> Thanks,
> > > >> Justine
> > > >>
> > > >> On Tue, Sep 22, 2020 at 8:52 AM Justine Olshan <
> jols...@confluent.io>
> > > >> wrote:
> > > >>
> > > >> > Hi all,
> > > >> >
> > > >> > I'd like to call a vote on KIP-516: Topic Identifiers. Here is the
> > > KIP:
> > > >> >
> > > >> >
> > > >>
> > >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-516%3A+Topic+Identifiers
> > > >> >
> > > >> > The discussion thread is here:
> > > >> >
> > > >> >
> > > >>
> > >
> https://lists.apache.org/thread.html/7efa8cd169cadc7dc9cf86a7c0dbbab1836ddb5024d310fcebacf80c@%3Cdev.kafka.apache.org%3E
> > > >> >
> > > >> > Please take a look and vote if you have a chance.
> > > >> >
> > > >> > Thank you,
> > > >> > Justine
> > > >> >
> > > >>
> > > >
> > >
>

Reply via email to