Hi, Jose,

Thanks for the updated KIP. Just a couple of minor comments.

41. Perhaps metadata.snapshot.min.records.size can just
be metadata.snapshot.min.records?

42. It's probably fine to change maxBytes for Fetch in a separate PR. I
brought this up since this KIP is changing the Fetch request.

Thanks,

Jun

On Fri, Oct 2, 2020 at 12:03 PM Jose Garcia Sancio <jsan...@confluent.io>
wrote:

> I read through KIP-630 and made the following minor changes.
>
>
> https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=158864763&selectedPageVersions=36&selectedPageVersions=35
>
> --
> -Jose
>

Reply via email to