-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21491/#review43176
-----------------------------------------------------------



core/src/main/scala/kafka/tools/MirrorMaker.scala
<https://reviews.apache.org/r/21491/#comment77245>

    Could we also add a metric that tracks the fraction of time that the 
consumer is blocked on putting data into the channel queue? That will give a 
clear indication weather the producer is slow.



core/src/main/scala/kafka/tools/MirrorMaker.scala
<https://reviews.apache.org/r/21491/#comment77246>

    Similarly, could we also add a metric that measures the fraction of time 
the producer is waiting on get a message from the channel. That's an indication 
weather the consumer is feeding enough data to the producer. Perhaps both can 
be tracked in the DataChannel class.


- Jun Rao


On May 15, 2014, 5:12 p.m., Guozhang Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21491/
> -----------------------------------------------------------
> 
> (Updated May 15, 2014, 5:12 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1453
>     https://issues.apache.org/jira/browse/KAFKA-1453
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Add a data channel size JMX
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/tools/MirrorMaker.scala 
> 26730c4a849045a6cd787b89ba5fa704e2524835 
> 
> Diff: https://reviews.apache.org/r/21491/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guozhang Wang
> 
>

Reply via email to