Thanks Mickael, I think adding the new Exception resolves my concerns. On Thu, Sep 3, 2020 at 9:47 AM Mickael Maison <mickael.mai...@gmail.com> wrote:
> Thanks Robert and Ryanne for the feedback. > > ReplicaAssignor implementations can throw an exception to indicate an > assignment can't be computed. This is already what the current round > robin assignor does. Unfortunately at the moment, there are no generic > error codes if it fails, it's either INVALID_PARTITIONS, > INVALID_REPLICATION_FACTOR or worse UNKNOWN_SERVER_ERROR. > > So I think it would be nice to introduce a new Exception/Error code to > cover any failures in the assignor and avoid UNKNOWN_SERVER_ERROR. > > I've updated the KIP accordingly, let me know if you have more questions. > > On Fri, Aug 28, 2020 at 4:49 PM Ryanne Dolan <ryannedo...@gmail.com> > wrote: > > > > Thanks Mickael, the KIP makes sense to me, esp for cases where an > external > > system (like cruise control or an operator) knows more about the target > > cluster state than the broker does. > > > > Ryanne > > > > On Thu, Aug 20, 2020, 10:46 AM Mickael Maison <mickael.mai...@gmail.com> > > wrote: > > > > > Hi, > > > > > > I've created KIP-660 to make the replica assignment logic pluggable. > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-660%3A+Pluggable+ReplicaAssignor > > > > > > Please take a look and let me know if you have any feedback. > > > > > > Thanks > > > >
