Hello Leah, Thanks for initiating this. I just have one minor clarification question here: the config "window.size.ms" seems to be used as the default window size when reading from a topic that represents windowed records right? I.e. if there are multiple topics that represent windowed records but their window sizes are different, with this config we can only read them with a single window size? If yes, could we rename the config as " default.window.size.ms" and make that clear in the description as well? Also we'd better also include its default value which I think would still be MAX_VALUE for compatibility.
Guozhang On Tue, Sep 8, 2020 at 9:38 AM Leah Thomas <ltho...@confluent.io> wrote: > Hey all, > > We should be good to wrap up voting now that the discussion has been > resolved. > > Cheers, > Leah > > On Wed, Sep 2, 2020 at 7:23 PM Matthias J. Sax <mj...@apache.org> wrote: > > > +1 (binding) > > > > On 8/26/20 8:02 AM, John Roesler wrote: > > > Hi all, > > > > > > I've just sent a new message to the DISCUSS thread. We > > > forgot to include the Scala API in the proposal. > > > > > > Thanks, > > > -John > > > > > > On Mon, 2020-08-24 at 18:00 -0700, Sophie Blee-Goldman > > > wrote: > > >> Thanks for the KIP! +1 (non-binding) > > >> > > >> Sophie > > >> > > >> On Mon, Aug 24, 2020 at 5:06 PM John Roesler <vvcep...@apache.org> > > wrote: > > >> > > >>> Thanks Leah, > > >>> I’m +1 (binding) > > >>> > > >>> -John > > >>> > > >>> On Mon, Aug 24, 2020, at 16:54, Leah Thomas wrote: > > >>>> Hi everyone, > > >>>> > > >>>> I'd like to kick-off the vote for KIP-659: Improve > > >>>> TimeWindowedDeserializer > > >>>> and TimeWindowedSerde to handle window size. > > >>>> > > >>> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-659%3A+Improve+TimeWindowedDeserializer+and+TimeWindowedSerde+to+handle+window+size > > >>>> Thanks, > > >>>> Leah > > >>>> > > > > > > > > -- -- Guozhang
