Hi Bruno, I read through your updated KIP and it looks good to me. I agree with adding the metric to keep track of crashed streams in replace of a list of dead streams.
best, Wlaker :) On Tue, Sep 1, 2020 at 1:05 PM Bruno Cadonna <br...@confluent.io> wrote: > Hi John, > > your proposal makes sense! I will update the KIP. > > Best, > Bruno > > On 01.09.20 17:31, John Roesler wrote: > > Hello Bruno, > > > > Thanks for the update! The KIP looks good to me; I only have > > a grammatical complaint about the proposed metric name. > > > > "Died" is a verb, the past tense of "to die", but in the > > expression,"x stream threads", x should be an adjective. To > > be fair, "died" is also the past participle of "to die", and > > participles can usually be used as adjectives. Maybe it > > sounds wrong to me because there's already a specifically > > adjectival form: "dead". So "dead-stream-threads" seems more > > natural. > > > > However, I'm not sure if that captures the specific meaning > > you're shooting for, namely that the metric counts only the > > threads that died exceptionally, vs. from calling > > "removeStreamThread()". What do you think of "crashed- > > stream-threads" instead? > > > > Thanks, > > -John > > > > On Tue, 2020-09-01 at 11:30 +0200, Bruno Cadonna wrote: > >> Hi, > >> > >> I updated the KIP with the feedback so far. I removed the API to close > >> the Kafka Streams client asynchronously, since it should be possible to > >> avoid the deadlock with the existing method and without a KIP. > >> > >> Please have a look at the updated KIP and let me know what you think. > >> > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-663%3A+API+to+Start+and+Shut+Down+Stream+Threads > >> > >> Best, > >> Bruno > >> > >> On 26.08.20 16:31, Bruno Cadonna wrote: > >>> Hi, > >>> > >>> I would like to propose the following KIP to start and shut down stream > >>> threads during execution as well as to shut down asynchronously a Kafka > >>> Streams client from an uncaught exception handler. > >>> > >>> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-663%3A+API+to+Start+and+Shut+Down+Stream+Threads+and+to+Request+Closing+of+Kafka+Streams+Clients > >>> > >>> > >>> Best, > >>> Bruno > > >
