-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19731/
-----------------------------------------------------------
(Updated May 10, 2014, 12:18 a.m.)
Review request for kafka.
Bugs: KAFKA-1328
https://issues.apache.org/jira/browse/KAFKA-1328
Repository: kafka
Description (updated)
-------
Included Jun's review suggestions part 2, except change to the commit() API
since it needs more thought
Review comments from Jun and Guozhang
Checked in ConsumerRecordMetadata
Fixed the javadoc usage examples in KafkaConsumer to match the API changes
Changed the signature of poll to return Map<String,ConsumerRecordMetadata> to
organize the ConsumerRecords around topic and then optionally around partition.
This will serve the group management as well as custom partition subscription
use cases
1. Changed the signature of poll() to return Map<String, List<ConsumerRecord>>
2. Changed ConsumerRecord to throw an exception if an error is detected for the
partition. For example, if a single large message is larger than the total
memory just for that partition, we don't want poll() to throw an exception
since that will affect the processing of the remaining partitions as well
Fixed MockConsumer to make subscribe(topics) and subscribe(partitions) mutually
exclusive
Changed the package to org.apache.kafka.clients.consumer from
kafka.clients.consumer
Changed the package to org.apache.kafka.clients.consumer from
kafka.clients.consumer
1. Removed the commitAsync() APIs 2. Changed the commit() APIs to return a
Future
Fixed configs to match the producer side configs for metrics
Renamed AUTO_COMMIT_ENABLE_CONFIG to ENABLE_AUTO_COMMIT_CONFIG
Addressing review comments from Tim and Guozhang
Rebasing after producer side config cleanup
Added license headers
Cleaned javadoc for ConsumerConfig
Fixed minor indentation in ConsumerConfig
Improve docs on ConsumerConfig
1. Added ClientUtils 2. Added basic constructor implementation for KafkaConsumer
Improved MockConsumer
Chris's feedback and also consumer rewind example code
Added commit() and commitAsync() APIs to the consumer and updated docs and
examples to reflect that
1. Added consumer usage examples to javadoc 2. Changed signature of APIs that
accept or return offsets from list of offsets to map of offsets
Improved example for using ConsumerRebalanceCallback
Improved example for using ConsumerRebalanceCallback
Included Jun's review comments and renamed positions to seek. Also included
position()
Changes to javadoc for positions()
Changed the javadoc for ConsumerRebalanceCallback
Changing unsubscribe to also take in var args for topic list
Incorporated first round of feedback from Jay, Pradeep and Mattijs on the
mailing list
Updated configs
Javadoc for consumer complete
Completed docs for Consumer and ConsumerRebalanceCallback. Added MockConsumer
Added the initial interfaces and related documentation for the consumer. More
docs required to complete the public API
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceCallback.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecord.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecords.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/consumer/OffsetMetadata.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FutureOffsetMetadata.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
a6423f4b37a57f0290e2048b764de1218470f4f7
clients/src/main/java/org/apache/kafka/common/utils/ClientUtils.java
PRE-CREATION
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerExampleTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/19731/diff/
Testing
-------
Thanks,
Neha Narkhede
