[GitHub] [kafka-site] scott-confluent commented on a change in pull request #282: bug fixes

[GitBox]

scott-confluent commented on a change in pull request #282:
URL: https://github.com/apache/kafka-site/pull/282#discussion_r465921715



##########
File path: 25/streams/developer-guide/write-streams.html
##########
@@ -90,22 +90,22 @@
               <p class="last">See the section <a class="reference internal" 
href="datatypes.html#streams-developer-guide-serdes"><span class="std 
std-ref">Data Types and Serialization</span></a> for more information about 
Serializers/Deserializers.</p>
           </div>
           <p>Example <code class="docutils literal"><span 
class="pre">pom.xml</span></code> snippet when using Maven:</p>
-          <pre class="line-numbers"><code class="language-xml"><dependency>
-    <groupId>org.apache.kafka</groupId>
-    <artifactId>kafka-streams</artifactId>
-    <version>{{fullDotVersion}}</version>
-</dependency>
-<dependency>
-    <groupId>org.apache.kafka</groupId>
-    <artifactId>kafka-clients</artifactId>
-    <version>{{fullDotVersion}}</version>
-</dependency>
+          <pre class="line-numbers"><code class="language-xml">&lt;dependency>
+    &lt;groupId>org.apache.kafka&lt;/groupId>

Review comment:
       theoretically it should be generated with html entities for both gt and 
lt, but the opening is the only one that matters for highlighting the syntax. 
it's not an easy thing to find/replace so we'd have to do an audit of all the 
docs.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org