Thanks for the KIP John. I share a similar concern with the motivation, it would be good if you could cast light on the actual downside of using a base class vs the interface, is it making the code fragile, or requiring redundant implementation, etc.
Boyang On Tue, Jul 21, 2020 at 2:19 PM Sophie Blee-Goldman <sop...@confluent.io> wrote: > Hey John, > > Thanks for the KIP. I know this has been bugging you :) > > That said, I think the KIP is missing some elaboration in the Motivation > section. > You mention a number of problems we've had and lived with in the past -- > could > you give an example of one, and how it would be solved by your proposal? > > By the way, I assume we would also need to deprecate all APIs that accept a > Windows > parameter in favor of new ones that accept a FixedSizeWindowDefinition? Off > the > top of my head that would be the windowedBy methods in KGroupedStream and > CogroupedKStream > > On Tue, Jul 21, 2020 at 1:46 PM John Roesler <vvcep...@apache.org> wrote: > > > Hello all, > > > > I'd like to propose KIP-645, to correct a small API mistake in Streams. > > Fixing this now allows us to avoid perpetuating the mistake in new work. > > For example, it will allow us to implement KIP-450 cleanly. > > > > The change itself should be seamless for users. > > > > Please see https://cwiki.apache.org/confluence/x/6SN4CQ for details. > > > > Thanks, > > -John > > >
