----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21123/#review42698 -----------------------------------------------------------
Ship it! Ship It! - Guozhang Wang On May 6, 2014, 5:56 p.m., Joel Koshy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21123/ > ----------------------------------------------------------- > > (Updated May 6, 2014, 5:56 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1437 > https://issues.apache.org/jira/browse/KAFKA-1437 > > > Repository: kafka > > > Description > ------- > > KAFKA-1437; Consumer metadata response should include (empty) coordinator > information if the coordinator is unavailable. > > > Diffs > ----- > > core/src/main/scala/kafka/api/ConsumerMetadataResponse.scala > 6807f9806fb155f6cdb1aaf63c14ac8ec180d779 > core/src/main/scala/kafka/client/ClientUtils.scala > fc9e08423a4127e1d64be1e62def567ea9eb80a3 > core/src/main/scala/kafka/javaapi/ConsumerMetadataResponse.scala > dfa9c42bcab39b56775fddedea1137a518349386 > core/src/test/scala/other/kafka/TestOffsetManager.scala > c468419297d297c2f320ff6d6dbbc5cd42380aa2 > core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala > d39a9a4bf89af493122b663f1378b9d01c9440ec > core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala > 19a86355844fd11550c8771165a86b6731a20d26 > > Diff: https://reviews.apache.org/r/21123/diff/ > > > Testing > ------- > > > Thanks, > > Joel Koshy > >
