----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21240/#review42692 -----------------------------------------------------------
Thanks for the comments. Scala ZookeeperConsumerConnector already has this check and it throws RuntimeException. I'll add a custom exception and unit test. -Harsha - Sriharsha Chintalapani On May 8, 2014, 10:06 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21240/ > ----------------------------------------------------------- > > (Updated May 8, 2014, 10:06 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1179 > https://issues.apache.org/jira/browse/KAFKA-1179 > > > Repository: kafka > > > Description > ------- > > KAFKA-1179. createMessageStreams() in javaapi.ZookeeperConsumerConnector does > not throw. > > > Diffs > ----- > > core/src/main/scala/kafka/javaapi/consumer/ZookeeperConsumerConnector.scala > 1f95d9b6a560b353dbd7fe8ad08495d47f9e1ac2 > > Diff: https://reviews.apache.org/r/21240/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
