Hi Dongjin, Hmm. I'm not sure I follow. How does deprecating DescribeLogDirsResponse.LogDirInfo help here? The issue is not so much the class, but the fact that it's exposed as a public API. So it seems appropriate to deprecate the methods that return it, but not the class itself, since we'll continue to use it internally.
best, Colin On Wed, Jul 8, 2020, at 07:41, Dongjin Lee wrote: > Hi Tom, > > Thanks for taking this issue. I opened a PR for this issue earlier, but > your KIP was submitted first. So I closed my one > <https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866169> > . > > I have a question: for consistency with other methods, how about > maintaining the signature of DescribeLogDirsResult#[all, values]? There is > an alternative approach to deprecate DescribeLogDirsResponse.[LogDirInfo, > ReplicaInfo]. (Please have a look at my proposal.) > > Best, > Dongjin > > +1. I updated the link to the discussion thread on your KIP document. > > On 2020/06/29 09:31:53, Tom Bentley <t...@redhat.com> wrote: > > Hi,> > > > > Does anyone have any comments about this? If not I'll likely start a > vote> > > in a couple of days.> > > > > Kind regards,> > > > > Tom> > > > > On Mon, Jun 8, 2020 at 4:56 PM Tom Bentley <tb...@redhat.com> wrote:> > > > > > Hi all,> > > >> > > > I've opened a small KIP seeking to deprecate and replace a couple of> > > > methods of DescribeLogDirsResult which refer to internal classes in > their> > > > return type.> > > >> > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158862109> > > >> > > > Please take a look if you have the time.> > > >> > > > Kind regards,> > > >> > > > Tom> > > >> > > >
