> On May 6, 2014, 11:19 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 166 > > <https://reviews.apache.org/r/21134/diff/1/?file=575738#file575738line166> > > > > This is a good catch. I'm wondering if we need both though. Shouldn't > > it suffice to call producerThreads.foreach(_awaitShutdown)?
Hey Neha, Yeah I changed that in the updated patch. - Guozhang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21134/#review42368 ----------------------------------------------------------- On May 6, 2014, 11:05 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21134/ > ----------------------------------------------------------- > > (Updated May 6, 2014, 11:05 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1432 > https://issues.apache.org/jira/browse/KAFKA-1432 > > > Repository: kafka > > > Description > ------- > > wait on producer shutdown latch instead of consumers > > > KAFKA-1432 Follow-up > > > Diffs > ----- > > core/src/main/scala/kafka/tools/MirrorMaker.scala > 12fa7979251da55b83564b25cbc8bca1f58ce387 > > Diff: https://reviews.apache.org/r/21134/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
