Thanks, Bruno. I updated the KIP, so hopefully it makes more sense. Thanks
to Matthias J. Sax and Piotr Smolinski for helping with details.

I welcome more feedback. Let me know if something doesn't make sense or I
need to provide more detail. Also, feel free to enlighten me. Thanks!

On Thu, Jun 11, 2020 at 1:11 PM Bruno Cadonna <br...@confluent.io> wrote:

> Hi Will,
>
> Thank you for the KIP.
>
> 1. Could you elaborate a bit more on the motivation in the KIP? An
> example would make the motivation clearer.
>
> 2. In section "Proposed Changes" you do not need to show the
> implementation and describe internals. A description of the expected
> behavior of the newly added methods should suffice.
>
> 3. In "Compatibility, Deprecation, and Migration Plan" you should
> state that the change is backward compatible because the two methods
> will be added and no other method will be changed or removed.
>
> Best,
> Bruno
>
> On Wed, Jun 10, 2020 at 10:06 AM William Bottrell <bottre...@gmail.com>
> wrote:
> >
> > Add currentSystemTimeMs and currentStreamTimeMs to ProcessorContext
> > <
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-622%3A+Add+currentSystemTimeMs+and+currentStreamTimeMs+to+ProcessorContext
> >
> >
> > I am extremely new to Kafka, but thank you to John Roesler and Matthias
> J.
> > Sax for pointing me in the right direction. I accept any and all
> feedback.
> >
> > Thanks,
> > Will
>

Reply via email to