Hi Sam, Thanks for the KIP.
Can you add some text clarifying whether a done task continues to be counted in the created-task-count? Looks good aside from that. best, Colin On Wed, Jun 17, 2020, at 12:31, Sam Pal wrote: > Hi all, > > I’d like to start a discussion about adding metrics to Trogdor to track > valuable information about agents and tasks. Specifically, exposing > metrics about the number of active agents and the number of created, > running, and done tasks in a Trogdor cluster. > > KIP: KIP-627 > (https://cwiki.apache.org/confluence/display/KAFKA/KIP-627%3A+Expose+Trogdor-specific+JMX+Metrics+for+Tasks+and+Agents) > JIRA: KAFKA-8528 (https://issues.apache.org/jira/browse/KAFKA-8528) > Pull Request: 8863 (https://github.com/apache/kafka/pull/8863) > > Looking forward to your thoughts and feedback! > > Best, > Sam >
