Thanks Boyang, that’s helpful! Have made the changes and updated the KIP now.
Joel > On 11 Jun 2020, at 5:38 PM, Boyang Chen <reluctanthero...@gmail.com> wrote: > > Thanks for the KIP Joel! Some quick questions and suggestions: > > 1. The KIP links to a wrong JIRA, which should be > https://issues.apache.org/jira/browse/KAFKA-6435 > 2. Typo: *deletes all topic that *-> *deletes all topics that* > 3. We need to explain in the Motivation section that we want to implement > an alternative approach for users to just delete internal topics they would > like to instead of using app-id-* as the regex > 4. In the Proposed Changes section, we need to explain the general usage > pattern, by doing a dry-run first and then choose whether to use the > `--internal-topics` flag or not. > 5. Seems we don't need bullet points for the Compatibility section? > > Boyang > > On Wed, Jun 10, 2020 at 2:16 PM Joel Wee <joel....@outlook.com> wrote: > >> Hi all >> >> I would like to start the discussion for KIP-623 which proposes adding an >> “internal-topics” option to the streams application reset tool: >> >> https://cwiki.apache.org/confluence/x/YQt4CQ >> >> Thanks >> >> Joel >>
