----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20997/#review42185 -----------------------------------------------------------
core/src/main/scala/kafka/producer/BaseProducer.scala <https://reviews.apache.org/r/20997/#comment75926> transit -> base core/src/main/scala/kafka/producer/BaseProducer.scala <https://reviews.apache.org/r/20997/#comment75927> sync send -> send synchronously core/src/main/scala/kafka/producer/BaseProducer.scala <https://reviews.apache.org/r/20997/#comment75928> The comment says block on a full buffer, but the config turns it off. core/src/main/scala/kafka/tools/MirrorMaker.scala <https://reviews.apache.org/r/20997/#comment75932> Now, there is a discrepancy in the names. MirrorMakerThread is too general and it is being referred to as consumerThread elsewhere. Should we just rename MirrorMakerThread to ConsumerThread? core/src/main/scala/kafka/tools/MirrorMaker.scala <https://reviews.apache.org/r/20997/#comment75930> i->producerIndex - Neha Narkhede On May 5, 2014, 5:31 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20997/ > ----------------------------------------------------------- > > (Updated May 5, 2014, 5:31 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1432 > https://issues.apache.org/jira/browse/KAFKA-1432 > > > Repository: kafka > > > Description > ------- > > Address Jun's comments > > > Add new TransitProducer > > > KAFKA-1432.v1 > > > Diffs > ----- > > core/src/main/scala/kafka/producer/BaseProducer.scala PRE-CREATION > core/src/main/scala/kafka/producer/ByteArrayPartitioner.scala > 988e4374d8c9b30c9333369741c30c75f0c44f2c > core/src/main/scala/kafka/producer/ConsoleProducer.scala > b19ab49c5fd57423e142f2f8afc5a77e653fd6ed > core/src/main/scala/kafka/tools/MirrorMaker.scala > e4d1a86f673f7df7fe71ce44e3550fcde8d01bba > perf/src/main/scala/kafka/perf/ProducerPerformance.scala > 1490bdb3d52d5c901d7a464222284935bda2f7ca > system_test/utils/kafka_system_test_utils.py > 423b512983c77b41b819912fe67b375a78faf644 > > Diff: https://reviews.apache.org/r/20997/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
