Thanks for the update, Mickael. Changes look good to me. On Fri, May 29, 2020 at 11:39 AM Mickael Maison <mickael.mai...@gmail.com> wrote:
> Quick update: > While implementing the KIP, we made a couple of changes: > - Use regular fields instead of flexible fields. We had to bump the > protocol version to detect compatibility so flexible fields were not > helping much for this low volume API. > - If no states are specified in the request, return all groups instead > of nothing. This allows clients to not necessarily know all the state > names but still retrieve them all. > > More details about these 2 points can be found in the PR discussion: > https://github.com/apache/kafka/pull/8238 > > On Mon, Mar 16, 2020 at 10:39 AM Mickael Maison > <mickael.mai...@gmail.com> wrote: > > > > Hi all, > > > > The vote has passed with 3 binding votes (Gwen, Colin and Rajini) and > > 5 non-binding votes (Kevin, Ryanne, Dongjin, Tom and David). > > Thanks everybody > > > > On Fri, Mar 13, 2020 at 11:09 AM Rajini Sivaram <rajinisiva...@gmail.com> > wrote: > > > > > > +1 (binding) > > > > > > Thanks for the KIP, Mickael! > > > > > > Regards, > > > > > > Rajini > > > > > > > > > On Thu, Mar 12, 2020 at 11:06 PM Colin McCabe <cmcc...@apache.org> > wrote: > > > > > > > Thanks, Mickael. +1 (binding) > > > > > > > > best, > > > > Colin > > > > > > > > On Fri, Mar 6, 2020, at 02:05, Mickael Maison wrote: > > > > > Thanks David and Gwen for the votes > > > > > Colin, I believe I've answered all your questions, can you take > another > > > > look? > > > > > > > > > > So far we have 1 binding and 5 non binding votes. > > > > > > > > > > On Mon, Mar 2, 2020 at 4:56 PM Gwen Shapira <g...@confluent.io> > wrote: > > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > Gwen Shapira > > > > > > Engineering Manager | Confluent > > > > > > 650.450.2760 | @gwenshap > > > > > > Follow us: Twitter | blog > > > > > > > > > > > > On Mon, Mar 02, 2020 at 8:32 AM, David Jacot < > dja...@confluent.io > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > +1 (non-binding). Thanks for the KIP! > > > > > > > > > > > > > > > > > > > > > > > > > > > > David > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Thu, Feb 6, 2020 at 10:45 PM Colin McCabe < cmccabe@ > apache. org > > > > ( > > > > > > > cmcc...@apache.org ) > wrote: > > > > > > > > > > > > > > > > > > > > >> > > > > > > >> > > > > > > >> Hi Mickael, > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> Thanks for the KIP. I left a comment on the DISCUSS thread as > well. > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> best, > > > > > > >> Colin > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> On Thu, Feb 6, 2020, at 08:58, Mickael Maison wrote: > > > > > > >> > > > > > > >> > > > > > > >>> > > > > > > >>> > > > > > > >>> Hi Manikumar, > > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> I believe I've answered David's comments in the DISCUSS > thread. > > > > Thanks > > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> On Wed, Jan 15, 2020 at 10:15 AM Manikumar < manikumar. > reddy@ > > > > gmail. com ( > > > > > > >>> manikumar.re...@gmail.com ) > > > > > > > >>> > > > > > > >>> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> wrote: > > > > > > >> > > > > > > >> > > > > > > >>> > > > > > > >>>> > > > > > > >>>> > > > > > > >>>> Hi Mickael, > > > > > > >>>> > > > > > > >>>> > > > > > > >>>> > > > > > > >>>> Thanks for the KIP. Can you respond to the comments from > David on > > > > > > >>>> > > > > > > >>>> > > > > > > >>> > > > > > > >>> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> discuss > > > > > > >> > > > > > > >> > > > > > > >>> > > > > > > >>>> > > > > > > >>>> > > > > > > >>>> thread? > > > > > > >>>> > > > > > > >>>> > > > > > > >>>> > > > > > > >>>> Thanks, > > > > > > >>>> > > > > > > >>>> > > > > > > >>> > > > > > > >>> > > > > > > >> > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
