> On May 1, 2014, 4:53 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/log/Log.scala, lines 458-459 > > <https://reviews.apache.org/r/20927/diff/1/?file=571972#file571972line458> > > > > Yes that's a good point - I can check this in with that edit.
you folks know best :) If logSegments is always sorted then that sounds good. Thanks for looking over this. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20927/#review41923 ----------------------------------------------------------- On April 30, 2014, 11:26 p.m., Alex Couture-Beil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20927/ > ----------------------------------------------------------- > > (Updated April 30, 2014, 11:26 p.m.) > > > Review request for kafka. > > > Repository: kafka > > > Description > ------- > > Added metric to track the minimum offset for each topic/partition > > > Diffs > ----- > > core/src/main/scala/kafka/log/Log.scala > f20c232e2daa63a10d91b965af52801af656477c > > Diff: https://reviews.apache.org/r/20927/diff/ > > > Testing > ------- > > > Thanks, > > Alex Couture-Beil > >
