----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20954/#review41924 -----------------------------------------------------------
Ship it! Ship It! - Guozhang Wang On May 1, 2014, 4:53 p.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20954/ > ----------------------------------------------------------- > > (Updated May 1, 2014, 4:53 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1412 > https://issues.apache.org/jira/browse/KAFKA-1412 > > > Repository: kafka > > > Description > ------- > > 1. Move createNewProducer() to TestUtils. 2. Add retries in the testcase that > auto-creates the topic. > > > Diffs > ----- > > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala > 839fd27ba8c1c8c55c0f9d89b11ea43718662df4 > core/src/test/scala/integration/kafka/api/ProducerSendTest.scala > 223033399a4448ea33e1434ca2742062f9fc0599 > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 49c7790c995bb2e79322eb148ab80d0dcccefed4 > > Diff: https://reviews.apache.org/r/20954/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
