----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20930/ -----------------------------------------------------------
Review request for kafka. Bugs: KAFKA-1433 https://issues.apache.org/jira/browse/KAFKA-1433 Repository: kafka Description ------- 1. Standardize all unit tests to use TestUtils.createProducer. 2. Increased the retry time in to TestUtils.createProducer. 3. Set # retries to 0 for all unit tests that expect the producer send to fail. Diffs ----- core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala 40a25a29cd6dbaa2a4df0c0b0f149205d3e7b544 core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala 97e3b1454457bdc8d31ee24b0edf85c85b815d55 core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala 6c3feacfb5ead7222e7f7962688894c4e9e886aa core/src/test/scala/unit/kafka/producer/ProducerTest.scala c3da69d3c2ef7b3bf276e3b748b5c213980a0e10 core/src/test/scala/unit/kafka/utils/TestUtils.scala 384c74e7c3985abff864e61dea5e530dbd189d5d Diff: https://reviews.apache.org/r/20930/diff/ Testing ------- Thanks, Jun Rao