FYI: I made a few clarifications to more carefully describe what happens with extra topic settings that the broker doesn't accept.
First, the description in the patterns table now is a bit more clear: Here "<topic-specific-setting>" must be any valid Kafka topic-level configurations for the version of the Kafka broker where the topic should be created; the Connect worker will fail upon startup if the "<topic-specific-setting>" is not known to the broker. Second, a new paragraph was added below the table to reiterate this: The Connect worker will fail upon startup if any of the topic-settings specified in the above configurations are not known to the Kafka broker. Third, the "Compatibility, Deprecation, and Migration Plan" section was changed to highlight a potential compatibility issue and behavioral change: These changes are backward compatible, and existing Connect distributed worker configurations will continue to work with no change in behavior, unless those configurations define unknown topic settings using any of the patterns defined above, in which case the Connect worker or MirrorMaker2 process will fail upon startup. I'll assume that everyone is okay with these changes, but if not, please respond and I can restart the voting if necessary. Randall On Mon, May 11, 2020 at 10:38 AM Konstantine Karantasis < konstant...@confluent.io> wrote: > This KIP falls in the category of necessary and straightforward KIPs. > Thanks for the nice write-up Randall. > > +1 (binding) > > Konstantine > > On Mon, May 11, 2020 at 8:00 AM Randall Hauch <rha...@gmail.com> wrote: > > > Ping for reviewers. > > > > I guess I never voted, so +1 (binding). > > > > On Thu, May 7, 2020 at 4:13 PM Christopher Egerton <chr...@confluent.io> > > wrote: > > > > > LGTM, +1 (non-binding) > > > > > > Thanks Randall! > > > > > > On Thu, May 7, 2020 at 11:01 AM Randall Hauch <rha...@gmail.com> > wrote: > > > > > > > I'd like to open the vote for KIP-605: > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-605%3A+Expand+Connect+Worker+Internal+Topic+Settings > > > > > > > > This is relatively straightforward, and the discussion thread had > just > > a > > > > few suggestions that have already been incorporated into the KIP. > > > > > > > > Best regards, > > > > > > > > Randall > > > > > > > > > >
