Hi Chris,
Thanks for your reminder, the original implement is deprecated, I just update the JIRA with the new PR link: https://github.com/apache/kafka/pull/8575 As question 2), I agree with you that we should consider both serialization and deserialization, and as you said, I only implement the serialization now. This is because the original serde implement is not symmetrical, the convertToConnect is a static method and can’t access the field in JsonConverter instance, maybe I should do some refactoring to implement the deserialization. Thanks, Cheng Pan Original Message Sender: Christopher Egerton<chr...@confluent.io> Recipient: dev<dev@kafka.apache.org> Date: Wednesday, Apr 15, 2020 02:28 Subject: Re: [Discuss] KIP-581: Value of optional null field which has default value Hi Cheng, Thanks for the KIP! I really appreciate the care that was taken to ensure backwards compatibility for existing users, and the minimal changes to public interface that are suggested to address this. I have two quick requests for clarification: 1) Where is the proposed "accept.optional.null" property going to apply? It's hinted that it'll take effect on the JSON converter but not actually called out anywhere. 2) Assuming this takes effect on the JSON converter, is the intent to alter the semantics for both serialization and deserialization? The code snippet from the JSON converter that's included in the KIP comes from the "convertToJson" method, which is used for serialization. However, based on https://github.com/apache/kafka/blob/ea47a885b1fe47dfb87c1dc86db1b0e7eb8a273c/connect/json/src/main/java/org/apache/kafka/connect/json/JsonConverter.java#L712-L713 it looks like the converter also inserts the default value for optional-but-null data during deserialization. Thanks again for the KIP! Cheers, Chris On Wed, Mar 18, 2020 at 12:00 AM Cheng Pan <379377...@qq.com> wrote: > Hi all, > > I'd like to use this thread to discuss KIP-581: Value of optional null > field which has default value, please see detail at: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-581%3A+Value+of+optional+null+field+which+has+default+value > > > There are some previous discussion at: > https://github.com/apache/kafka/pull/7112 > > > I'm a beginner for apache project, please let me know if I did any thing > wrong. > > > Best regards, > Cheng Pan
