Thanks for the structure change Boyang. And I agree with you on the weak proposal part, I have adjusted it according to your suggestion. Thanks again!
Boyang Chen <reluctanthero...@gmail.com> 于2020年4月16日周四 下午2:39写道： > Thanks for the KIP Xiang! > > I think the motivation looks good, and I just did a slight structure change > to separate "Proposed Changes" and "Public Interfaces", hope you don't > mind. > > However, "we can determine whether the producer client is already in error > state in abortTransaction" sounds a bit weak about the actual proposal, > instead we could propose something as "we would remember whether a fatal > exception has already been thrown to the application level, so that in > abort transaction we will not throw again, thus making the function safe to > be called in an error state". > > Other than that, I think the KIP is in pretty good shape. > > Boyang > > On Wed, Apr 15, 2020 at 7:07 PM 张祥 <xiangzhang1...@gmail.com> wrote: > > > Hi everyone, > > > > I have opened a small KIP about safely aborting transaction during > > shutdown. I'd like to use this thread to discuss about it and any > feedback > > is appreciated (sorry for earlier KIP number mistake). Here is a link to > > KIP-596 : > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-596%3A+Safely+abort+Producer+transactions+during+application+shutdown > > > > Thank you! > > >
