Hey Matthias,

Thanks for picking this up! This'll be really nice for testing in
particular.

My only question is, do we want to make this available for use with custom
state stores as well? I'm not sure how common custom stores are in practice,
but I imagine when they *are* used, they're likely to be used all
throughout the
topology. So being able to set this one config would probably be a big win.

That said, it would be a nontrivial change given the different store types.
It's unfortunate that we can't just accept a StoreSupplier class to
configure this;
we'd need one for KV, window, and session stores each. We could just
add three configs, but that's not very appealing when it should take one.

Maybe we could define a new "store supplier"-supplier type class, which
maps the store supplier for each of the three store types? Just throwing out
ideas.

I'm actually fine with passing on the custom state stores for this feature
if
it doesn't sound worth the effort -- just wanted to put the thought out
there,
and see if anyone comes up with a more elegant solution.

Thanks for the KIP!
Sophie

On Thu, Apr 9, 2020 at 3:50 PM Matthias J. Sax <mj...@apache.org> wrote:

> Hi,
>
> I would like to propose a small KIP to simplify the switch from RocksDB
> to in-memory stores in Kafka Stream:
>
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-591%3A+Add+Kafka+Streams+config+to+set+default+store+type
>
> Looking forward to your feedback.
>
>
> -Matthias
>
>

Reply via email to