----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20718/#review41501 -----------------------------------------------------------
core/src/main/scala/kafka/server/BrokerStates.scala <https://reviews.apache.org/r/20718/#comment74944> Just a thought: I'm wondering if it is better to have a bit-vector approach for states; although that will limit the number of possible states - but I think that is fine. The main reason for this is that it will enable composing simultaneous states. E.g., in this approach you cannot distinguish state 5 from state 3 (if a shutting down broker is the controller). Although we can probably infer that from the fact that the other brokers are likely in state (2) or by looking at the active controller count separately. Still, we currently allow more than one broker to shut down. It also _might_ help catch erroneous dual states (due to bugs). What you have is probably fine for lifecycle states (except for the above caveat). However, if we ever want to allow more-than-lifecycle states (e.g., under-replicated is a state we _might_ want to include on this - even though we have a separate URP mbean and it's not a lifecycle state; another example is "loading consumer offsets"). core/src/main/scala/kafka/server/KafkaServer.scala <https://reviews.apache.org/r/20718/#comment74947> I think we can drop "CurrentBroker". Just "-State" (because it is shorter, as meaningful, and also because brokerstate does not fully fit with controllerstate) core/src/main/scala/kafka/server/KafkaServerStartable.scala <https://reviews.apache.org/r/20718/#comment74959> Unused - Joel Koshy On April 25, 2014, 5:25 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20718/ > ----------------------------------------------------------- > > (Updated April 25, 2014, 5:25 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1384 > https://issues.apache.org/jira/browse/KAFKA-1384 > > > Repository: kafka > > > Description > ------- > > KAFKA-1384: Logging kafka state metric > > > Diffs > ----- > > core/src/main/scala/kafka/controller/KafkaController.scala > 933de9dd324c7086efe6aa610335ef370d9e9c12 > core/src/main/scala/kafka/log/Log.scala > 46df8d99d977a3b010a9b9f4698187fa9bfb2498 > core/src/main/scala/kafka/log/LogManager.scala > ac67f081e6219fd2181479e7a2bb88ea6044e6cc > core/src/main/scala/kafka/server/BrokerStates.scala PRE-CREATION > core/src/main/scala/kafka/server/KafkaServer.scala > c208f83bed7fb91f07fae42f2b66892e6d46fecc > core/src/main/scala/kafka/server/KafkaServerStartable.scala > acda52b801714bcc182edc0ced925f0e4b493fc1 > > Diff: https://reviews.apache.org/r/20718/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Chen > >
